chore: two-line trace view (1) - #36025
Merged
Pavel Feldman (pavelfeldman) merged 1 commit intoMay 22, 2025
Merged
Conversation
Pavel Feldman (pavelfeldman)
changed the title
Yury Semikhatsky (yury-s)
approved these changes
May 20, 2025
| @@ -0,0 +1,306 @@ | |||
| /** | |||
There was a problem hiding this comment.
What's the difference with packages/playwright-core/src/protocol/debug.ts and packages/protocol/src/metainfo.ts?
| /KEY UP Shift/, | ||
| /MOUSE MOVE/, | ||
| /MOUSE DOWN/, | ||
| /MOUSE MOVE/, |
There was a problem hiding this comment.
what about the coordinates?
| expect(msg.text()).toEqual('canvas drawn: [0,91,11,20]'); | ||
|
|
||
| const snapshot = await traceViewer.snapshotFrame('page.goto'); | ||
| const snapshot = await traceViewer.snapshotFrame('NAVIGATE'); |
There was a problem hiding this comment.
Why not goto?
Pavel Feldman (pavelfeldman)
force-pushed
the
new_trace_look
branch
3 times, most recently
from
May 22, 2025 01:21
62eb6d2 to
a333e70
Compare
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
force-pushed
the
new_trace_look
branch
from
May 22, 2025 01:46
a333e70 to
e15870d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
force-pushed
the
new_trace_look
branch
from
May 22, 2025 15:52
e15870d to
9675bd2
Compare
Contributor
Test results for "tests 1"4 failed 7 flaky39208 passed, 804 skipped Merge workflow run. |
Nanne (whazor)
pushed a commit
to whazor/playwright-trace-viewer-plus
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.